WIP: [DO NOT MERGE] Release v3.3.5 #5666
Conversation
jameslamb
requested review from
StrikerRUS,
Laurae2,
guolinke,
chivee,
btrotta,
shiyu1994,
hzy46 and
tongwu-sh
as code owners
jameslamb
changed the title
|
/gha run r-configure |
2 similar comments
|
/gha run r-configure |
|
/gha run r-configure |
|
/gha run r-configure |
|
/gha run r-configure |
|
ugh, the generating the To work around that, I just manually re-generated docker run \
--rm \
-v $(pwd):/opt/LightGBM \
-w /opt/LightGBM \
-t ubuntu:20.04 \
./R-package/recreate-configure.shthen pushed it here: ca035b2 |
|
I believe this branch is ready. @guolinke @shiyu1994 @jmoralez @btrotta @StrikerRUS will you please take a look and approve if you agree? I'm going to be traveling for the next day or two, but if this gets sufficient approvals (at least one from @shiyu1994 ), I can submit the R package to CRAN once I'm back...and then eventually finish up the release (PyPI, NuGet, GitHub, etc.) if/when that submissions passes checks on CRAN. |
|
I just submitted v3.3.5 of the R package to CRAN. @shiyu1994 , you should receive an email from them asking you to click a confirmation link.
Submitted with the following note (just saving here so I can have it later for when I add it to |
|
@shiyu1994 did you receive an email from CRAN? It looks like v3.3.5 was routed to "archive": https://cran.r-project.org/incoming/archive/. Also, is it absolutely required by Microsoft that the maintainer on the R package be you or another Microsoft employee? If not, in the next release could we change it to me, so that I can do this myself? |
|
@jameslamb Yes, I've click the confirmation quickly after I received the email. Sorry for the late response.
I'm not sure if there's such restriction. Will figure it out. If not, I will transfer the maintainer of R package to you. Thanks for your contribution! |
|
Thank you! @shiyu1994 can you please check if they sent another email (after the confirmation)? I'm worried that the v3.3.5 release got put into "archive". I wonder if they sent you another email saying there's something wrong with the submission. |
|
@shiyu1994 I'm sorry to keep tagging you, but we don't have much time left to prevent CRAN from removing the R package. Can you please check your email for a message from them explaining why our submission was rejected? |
|
@jameslamb Yes, I got an email from CRAN again yesterday. Just planed to send it here. But I was busy about finalizing our NeurIPS paper yesterday. |
|
It seems that we still need some additional work. |
|
Is that the only one? If so can you please reply with the following:
|
Yes. the previous email before this one from CRAN is the confirmation about uploading our 3.3.5 package on Jan 12th.
Just replied the email as you asked. |
|
Ok thanks for checking! Hopefully they will clarify what they want from us. |
|
Seems that the issue was related the too long check time. |
|
lightgbm 3.3.5 is now available on CRAN. |
|
🎉 Amazing, thanks @shiyu1994 !!!! I'm really happy to see that v3.3.5 is up at https://cran.r-project.org/web/packages/lightgbm/index.html
and checks at https://cran.r-project.org/web/checks/check_results_lightgbm.html seem to be going well so far
For example, the Once that page shows no more ERRORs or WARNINGs, I'll finish the v3.3.5 with the other non-R components (Python, GitHub release, NuGet, etc.) |
|
🎉
https://cran.r-project.org/web/checks/check_results_lightgbm.html Thanks so much for the help @shiyu1994 ! I'll finish up the rest of the v3.3.5 release tonight, now that CRAN is happy again. |
|
Alright, continuing on this release! I'll continue editing this comment as things progress, similar to #5619 (comment).
git tag v3.3.5
git push upstream v3.3.5(I use
git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable v3.3.5
git push upstream stablehttps://github.com/microsoft/LightGBM/tags
see https://pypi.org/project/lightgbm/
downloaded the files from the release, then uploaded them like this: twine upload -u ${PYPI_USER} dist/*
|
|
This release is complete. Thanks everyone!! |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Similar to #5619, this is an unusual release.
This PR, for
v3.3.5, just contains the changes on top ofv3.3.4needed to prevent the R package from being archived by CRAN. See #5661.THIS PR SHOULD NEVER BE MERGED
Setup
I created a new branch,
release/v3.3.4, which contains only:v3.3.4master(f0cfbff)how I did that (click me)
Tags and artifacts should be made directly from this
release_v3.3.4branch instead ofmaster.Release checklist:
Copied from #5525.
configurefile of R-package:/gha run r-configure.development.modefromunreleasedtoreleasein pkgdown config file.v*tag to triggerGitHubReleaseaction at Azure Pipelines.Draftto normal one.stabletag at GitHub.What about the changelog?
As described in #4930 (comment), doing this interferes with the automatic changelog generation we get from the release-draft bot.
So just like @StrikerRUS did in #4930 and I did in #5525 and #5619, I've included the current draft changelog here, as well as the one saved in the comments on #4930.
changelog from v3.3.1 to when v3.3.2 was created (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.2 was created to date of v3.3.3 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.3 was created to v3.3.4 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.4 was created to today (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.